Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @NotNull to required parameters of DW resource methods #373

Merged

Conversation

@kelnos
Copy link
Member

commented Aug 19, 2019

This also boxes all primitive types in resource method args so that Jersey can actually apply the @NotNull annotation. If primitive types are used, and the param isn't provided in the request, Jersey will just default it to 0/0.0/false.

Addresses #372

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
Add @NotNull to required parameters of DW resource methods
This also boxes all primitive types in resource method args so that
Jersey can actually apply the @NotNull annotation.  If primitive types
are used, and the param isn't provided in the request, Jersey will just
default it to `0`/`0.0`/`false`.

@kelnos kelnos requested a review from blast-hardcheese Aug 19, 2019

@blast-hardcheese
Copy link
Collaborator

left a comment

No objections

@blast-hardcheese blast-hardcheese merged commit 3c39ad0 into twilio:master Sep 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.