Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 405 Fix regression in empty string Form param handling in AkkaHttpServer #408

Merged
merged 6 commits into from Oct 3, 2019

Conversation

@efossier
Copy link
Contributor

commented Sep 26, 2019

This fixes #405 by removing the contentRequiredUnmarshaller from the generated form param parsing code. This prevented clients from sending empty string values to String form params which was a regression from earlier versions of guardrail.

The contentRequiredUnmarshaller is not required because for other types, the type specific parser should fail on an empty string input, however for String this should be allowed.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
Copy link
Collaborator

left a comment

lgtm, thanks!

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

Looks like a formatting issue, could you sbt format and commit the result? No other objections

Evan Fossier
Copy link
Collaborator

left a comment

Slick! Thank you!

@blast-hardcheese blast-hardcheese merged commit 2ab238e into twilio:master Oct 3, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.