-
Notifications
You must be signed in to change notification settings - Fork 29
fix: Add edge parameter support for regional authentication #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add edge parameter support for regional authentication #298
Conversation
Add edge parameter to profile configuration to support regional Twilio endpoints. Regional endpoints require both region and edge location (e.g., api.sydney.au1.twilio.com). Changes: - Add edge parameter to ConfigDataProfile class - Add TWILIO_EDGE environment variable support - Update addProfile() with backward compatibility for 5-param calls - Update buildClient() to prioritize edge: env > profile > config - Add regional authentication error guidance for 20003 errors - Add comprehensive test coverage for edge functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflict in buildClient() by integrating profile.edge support with new REGION_EDGE_MAP and deprecation warning logic from main. Updated edge resolution to: env > profile.edge > config.edge, while preserving the new automatic edge mapping for regions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SonarCloud Scan Failure - Fork PR LimitationThe test jobs are showing as failed, but all 197 tests are actually passing ✅ The failure is only due to the SonarCloud scan, which shows: Root CauseThis is a GitHub security limitation with fork-based PRs:
Verification
Resolution Options
The code changes are working correctly and all functional tests pass. |
The changelog is auto-populated by the automated workflow, so removing manual entries as requested by reviewer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
tiwarishubham635 as mentioned, I do not have access to the SonarCloud components, so cannot pass these. Let me know next steps. As mentioned this is related to twilio/twilio-cli#669 and https://github.com/twilio-internal/docs/pull/5655, which I have updated |
tiwarishubham635
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thank you so much |
### [8.2.4](8.2.3...8.2.4) (2025-12-08) ### Library - Fixes * Add edge parameter support for regional authentication ([#298](#298)) ([9f023f4](9f023f4)) * Regional Endpoint Processing ([#296](#296)) ([b3786ca](b3786ca)), closes [#297](#297) ### Library - Chores * add npm token for semantic-release authentication ([e13b03c](e13b03c)) * Add trusted publisher ([#299](#299)) ([a544aea](a544aea)) * remove registry url ([6a1c488](6a1c488))
Summary
Add edge parameter support to profile configuration for regional Twilio endpoints. Regional endpoints require both region and edge location (e.g., api.sydney.au1.twilio.com).
Changes:
edgeparameter to ConfigDataProfile class for per-profile storageTWILIO_EDGEenvironment variable support to getProfileFromEnvironment()Test plan
Checklist
🤖 Generated with Claude Code