From 84d5796015056358d3da09b88e708ffa6c9cf684 Mon Sep 17 00:00:00 2001
From: Sindhura Chamala <sindhura.chamala@gmail.com>
Date: Fri, 28 Jan 2022 11:00:28 +0530
Subject: [PATCH] fix: Correct terminology in testing workflow (#370)

* Correct terminology in testing workflow

* adjust changes

Co-authored-by: schamala <schamala@twilio.com>
---
 ...platform-executables-acceptance-tests.yml} | 92 ++++++++++---------
 1 file changed, 48 insertions(+), 44 deletions(-)
 rename .github/workflows/{platform-exec-sanity-tests.yml => platform-executables-acceptance-tests.yml} (59%)

diff --git a/.github/workflows/platform-exec-sanity-tests.yml b/.github/workflows/platform-executables-acceptance-tests.yml
similarity index 59%
rename from .github/workflows/platform-exec-sanity-tests.yml
rename to .github/workflows/platform-executables-acceptance-tests.yml
index d2f76095c..1f420c238 100644
--- a/.github/workflows/platform-exec-sanity-tests.yml
+++ b/.github/workflows/platform-executables-acceptance-tests.yml
@@ -1,13 +1,18 @@
-name: Platform Executable Sanity testing
+name: Platform Executable Acceptance Testing
 on:
   workflow_dispatch:
   workflow_run:
     # wait for Platform Executable Release to complete
-    workflows: ["Debian Executable Release", "Macos Executable Release", "Windows Executable Release"]
+    workflows:
+      [
+        "Debian Executable Release",
+        "Macos Executable Release",
+        "Windows Executable Release",
+      ]
     branches: [main]
     types:
       - completed
- 
+
 jobs:
   get-branch:
     name: Get Current Branch Name
@@ -52,21 +57,21 @@ jobs:
   get-tag:
     runs-on: ubuntu-latest
     outputs:
-     TAG_NAME: ${{steps.get-tag.outputs.TAG_NAME}}
+      TAG_NAME: ${{steps.get-tag.outputs.TAG_NAME}}
     steps:
-     - uses: actions/checkout@v2
-     - name: Getting latest tag
-       id: get-tag
-       run: |
-        git fetch --prune --unshallow
-        echo "::set-output name=TAG_NAME::$(git describe --tags $(git rev-list --tags --max-count=1))"
+      - uses: actions/checkout@v2
+      - name: Getting latest tag
+        id: get-tag
+        run: |
+          git fetch --prune --unshallow
+          echo "::set-output name=TAG_NAME::$(git describe --tags $(git rev-list --tags --max-count=1))"
   platform-exec-test:
     name: Test for ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     needs: [get-tag, wait-for-releases]
     strategy:
-     fail-fast: false
-     matrix:
+      fail-fast: false
+      matrix:
         include:
           - os: ubuntu-latest
             extension_type: '.deb'
@@ -75,38 +80,37 @@ jobs:
             extension_type: '.pkg'
             cmds_to_execute: sudo installer -pkg twilio-${{ needs.get-tag.outputs.TAG_NAME }}.pkg -target ~/
     steps:
-       - name: Checkout cli repo
-         uses: actions/checkout@v2
-       - name: Perform sanity install and test on binaries
-         env:
+      - name: Checkout cli repo
+        uses: actions/checkout@v2
+      - name: Perform install and test binaries
+        env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-         run: |
-            gh release download ${{ needs.get-tag.outputs.TAG_NAME }} --pattern '*${{matrix.extension_type}}'
-            ${{matrix.cmds_to_execute}}
-            ls
-            twilio --version
-            twilio api --help
+        run: |
+          gh release download ${{ needs.get-tag.outputs.TAG_NAME }} --pattern '*${{matrix.extension_type}}'
+          ${{matrix.cmds_to_execute}}
+          ls
+          twilio --version
+          twilio api --help
   platform-exec-test-Windows:
-     name: Test for Windows
-     runs-on: windows-latest
-     needs: [get-tag]  
-     steps:
-       - name: Checkout cli repo
-         uses: actions/checkout@v2
-       - name: Perform sanity install and tests on Windows
-         env:
+    name: Test for Windows
+    runs-on: windows-latest
+    needs: [get-tag]
+    steps:
+      - name: Checkout cli repo
+        uses: actions/checkout@v2
+      - name: Perform install and test the Windows executable
+        env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-         run: |
-            gh release download ${{ needs.get-tag.outputs.TAG_NAME }} --pattern '*.exe'
-            ls
-            iwr -useb get.scoop.sh | iex
-            scoop install gsudo
-            ./twilio-${{ needs.get-tag.outputs.TAG_NAME }}.exe /S
-            sleep 100
-            $env:Path += ";C:\Program Files (x86)\twilio-cli\bin"
-            $Env:Path
-            cd C:\"Program Files (x86)\twilio-cli"
-            dir
-            twilio --version
-            twilio api --help
-         
+        run: |
+          gh release download ${{ needs.get-tag.outputs.TAG_NAME }} --pattern '*.exe'
+          ls
+          iwr -useb get.scoop.sh | iex
+          scoop install gsudo
+          ./twilio-${{ needs.get-tag.outputs.TAG_NAME }}.exe /S
+          sleep 100
+          $env:Path += ";C:\Program Files (x86)\twilio-cli\bin"
+          $Env:Path
+          cd C:\"Program Files (x86)\twilio-cli"
+          dir
+          twilio --version
+          twilio api --help