Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use go install instead of go get #153

Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix: use go install instead of go get #153

merged 2 commits into from
Apr 1, 2022

Conversation

beebzz
Copy link

@beebzz beebzz commented Mar 31, 2022 •
edited
Loading

As of Go 1.18, dependencies such as goimports need to be installed via go install instead of go get (reference)

Also adjusts the goimports rule to run go mod tidy immediately after goimports

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@beebzz beebzz merged commit 283c98a into main Apr 1, 2022
@beebzz beebzz deleted the v1.18-followup branch April 1, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beebzz @childish-sambino