Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support required resource properties with names containing periods #733

Conversation

Hunga1
Copy link
Contributor

@Hunga1 Hunga1 commented Jan 27, 2022

Adds support for using names containing periods in required resource properties. Updates undefined checks for those required properties using bracket notation instead of dot notation to avoid the interpreter from attempting to reference nested object properties when encountering property names containing periods.

Changes:

  • Undefined check statements for required resource properties (options) now use bracket notation over dot notation
  • Updates integration tests to support property names containing periods by wrapping property names in quotes
  • Disables jshint error recommending dot notation over bracket notation object property references

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@Hunga1 Hunga1 merged commit 1a3e3e1 into twilio:main Jan 27, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants