Fix instance resource retrieving wrong URI #71

Merged
merged 1 commit into from Jul 3, 2012

2 participants

@kevinburke

Currently the instance resources are getting their URI set from the api (which includes the .json instruction) instead of building them programmatically.

You can trigger the bug by retrieving an instance resource from the API either from the list resource or the instance resource, and then trying to retrieve it again.

@kyleconroy

+1, looks good. It's a subtle bug.

@kyleconroy kyleconroy closed this Jul 3, 2012
@kyleconroy kyleconroy reopened this Jul 3, 2012
@kevinburke kevinburke merged commit 2e24838 into master Jul 3, 2012
@beachboysapp beachboysapp pushed a commit to beachboysapp/urgentMe that referenced this pull request Mar 1, 2014
Kevin Burke Don't update the URI when updating a resource
An InstanceResource would overwrite its URI if properties were retrieved or
updated on the object. However the URI returned from the API already has
'.json' appended to it, so when the library tries to also append .json, the
extension has been appended twice.

This is a similar bug to twilio/twilio-php#71.
I have checked to try and make sure it cannot appear under any other
circumstances in the library.
3560a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment