Stops rescuing Exception, rescues StandardError instead. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
philnash
added a commit
that referenced
this pull request
Apr 20, 2015
Stops rescuing Exception, rescues StandardError instead.
ajtack
pushed a commit
to ajtack/twilio-ruby
that referenced
this pull request
Apr 28, 2017
Update java next-gen wireless/ snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You shouldn't rescue
Exceptionin Ruby. It will rescueNoMemoryErrorandInterruptand others you don't really want to rescue from in this case.StandardError, which is the default when just usingrescue, is better, but ideally this would rescue specific errors that we want to rescue from. Perhaps looking at Faraday's list of errors or this suggestion from Tammer Saleh would be better. The least we can do is stop rescuingExceptionthough.