Rake + Gem refresh #88

Merged
merged 5 commits into from Jul 25, 2014

Projects

None yet

3 participants

@karlfreeman
Contributor
  • For the most part this is cosmetic, aside from ensuring development_dependencies are only for development.
karlfreeman added some commits Mar 19, 2014
@karlfreeman karlfreeman refresh Rakefile
- replace Gem::PackageTask with Bundler::GemHelper in
- add description to Rspec Rake task as well as add a common alias for test to simply run spec
0a87f4c
@karlfreeman karlfreeman refresh .gemspec
- ensure .gemspec is using latest Gem::Specification behaviour
- make sure that test gems are not a 'add_development_dependency'
908713f
@karlfreeman karlfreeman use new Rake tasks aed66db
This was referenced Mar 19, 2014
@dougblack dougblack and 1 other commented on an outdated diff Mar 24, 2014
test-install:
bundle install
test:
- bundle exec rake spec
+ rake spec
@dougblack
dougblack Mar 24, 2014 Member

What's the basis here?

@karlfreeman
karlfreeman Mar 24, 2014 Contributor

The basis for this is that one would hope that the developer is using --binstubs. However we could err on the safe side instead and bundle exec still?

@dougblack
dougblack Mar 24, 2014 Member

Yeah. We always tend to err on the safe side when it comes to setting up these libraries. Assumptions about dev environments usually come back to haunt us in the form of frustrated developers unable to get the gem working. :)

@karlfreeman
karlfreeman Mar 24, 2014 Contributor

👻 👍

@karlfreeman karlfreeman added a commit to karlfreeman/twilio-ruby that referenced this pull request Mar 24, 2014
@karlfreeman karlfreeman temporarily ensure test dependencies are installed #88 should fix this 564cfe0
@dougblack
Member

This build isn't finishing either.

@carlosdp
Contributor

👍 let's get this merged so we can deal with #89

@carlosdp carlosdp merged commit b076178 into twilio:master Jul 25, 2014

1 check passed

default The Travis CI build passed
Details
@karlfreeman karlfreeman deleted the karlfreeman:rake-gem-refresh branch Jul 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment