Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap Corruption Crashes - Multiparty Rooms #74

Closed
mknippen opened this issue Feb 25, 2017 · 17 comments

Comments

Projects
None yet
3 participants
@mknippen
Copy link

commented Feb 25, 2017

We performed tests with six users, and almost all of us had crashes with the current version (beta 8). Crashlytics noted at least 7 different crashes in the TwilioVideo codebase. I will be happy to provide stack traces for each one.
screen shot 2017-02-25 at 10 12 56 am

@mknippen

This comment has been minimized.

Copy link
Author

commented Feb 25, 2017

Would you like each one as a separate GitHub issue, so it can be more easily tracked?

@idelgado

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

@mknippen yes, that would be really helpful. Please add the stack trace for each and we'll start investigating.

@mknippen

This comment has been minimized.

Copy link
Author

commented Feb 27, 2017

screen shot 2017-02-27 at 2 11 46 pm

Attached finished demo results. We had 9 users, and 30 crashes. I will update with individual crash logs today.

@ceaglest

This comment has been minimized.

Copy link
Member

commented Feb 27, 2017

Thanks for filing issues with stack traces @mknippen.

We have customers using the iOS SDK in production who are not seeing the kind of crash rates that you are, so we may contact you for more info on your particular use case. Nevertheless, there are some memory and threading bugs that we are still working to resolve, and will keep you in the loop as we address these issues.

Best,
Chris

@mknippen

This comment has been minimized.

Copy link
Author

commented Feb 27, 2017

@ceaglest absolutely, and sorry for the GitHub notification overload (I'm sure). I'm here to help in anyway that I can. I'm able to hop on a phone call or screenshare to show you what I'm doing at any point if you would like.

To the best of my knowledge, I'm not hacking anything or using anything outside of the SDK you published. I make no reference to AVFoundation or AudioToolbox at all, and let the framework handle it all directly.

@ceaglest

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

@mknippen Other than #78, and #85 it looks the issues have the same underlying problem - heap corruption. Each crashing call is trying to allocate some memory, but the system libraries are detecting corruption and crashing from there.

Edit: To provide a little more info about the use case, these crashes are seen in multi-party Rooms sharing audio.

@ceaglest ceaglest changed the title Several Twilio Crashes Heap Corruption Crashes - Multiparty Rooms Mar 1, 2017

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in consume_record.

Biggest crash on the demo. 8 crashes from 6 users in 30 minutes.

TwilioVideo.consume_record.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in resip::ConnectionBase::preparseNewBytes due to heap corruption.

resip-ConnectionBase-preparse.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in resip::ConnectionBase::getWriteBufferForExtraBytes due to heap corruption.

4 crashes from 4 users in 30 minutes.

resip-ConnectionBase.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in cricket::P2PTransportChannel::IsPingable likely due to heap corruption.

2 crashes from 2 users in 30 minutes

cricket-P2PTransportChannel.crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in resip::Helper::makeResponse due to heap corruption.

resip-Helper.crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in rtc::ByteBufferWriter::~ByteBufferWriter() due to heap corruption.

rtc-ByteBufferWriter-crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in sigslot::signal2<cricket::TransportChannel*, rtc::SentPacket const&, sigslot::single_threaded> likely due to heap corruption.

sigslot-signal2.crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in resip::TransactionState::processSipMessageAsNew due to heap corruption.

resip-TransactionState.crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Crash in twilio::signaling::SipTU:process due to heap corruption.

twilio-signaling.crash.txt

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

@mknippen our latest 1.0.0-beta11 release should address the source of these heap corruption crashes. Give it a try if you have the chance.

@ceaglest

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

Closing out this issue, since we haven't gotten any new reports of this type of crash since 1.0.0-beta11. Please re-open if you are still experiencing issues.

@ceaglest ceaglest closed this Mar 28, 2017

paynerc pushed a commit that referenced this issue Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.