OpenBSD box: Fix hostname (wrong version number) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to user variables for the version numbering to reduce the risk of a similar error in the future.
jage
changed the title
walro
reviewed
Dec 11, 2017
| "mirror": "https://fastly.cdn.openbsd.org" | ||
| "mirror": "https://fastly.cdn.openbsd.org", | ||
| "major_version": "6", | ||
| "minor_version": "2" | ||
| }, |
There was a problem hiding this comment.
could possible add
"version": "{{user `major_version`}}.{{user `minor_version`}}"
to improve readability later on
There was a problem hiding this comment.
not sure what to call the dotless version though, so we can maybe just leave it:)
There was a problem hiding this comment.
Hehe, yeah that's what stopped me. :) Not sure either what to call it, I think it might just get confusing. The important thing is to not duplicate the version specification, how it's formatted depends on the usage ..
walro
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to user variables for the version numbering to reduce the risk of
a similar error in the future.