[#81] Use upstream buildbot version

[adiroiban]

Scope

This tries to fix #81 by using an upstream version of buildbot.

Changes

buildbot eight branch (unreleased) branch is used, as 0.8.12 is buggy.
Also, the branch is still hosted in the braid/buildbot fork so that we can control its updates.

PB listened was removed as I don't think that it is used.

Some changes from the webstatus templates were reverted so that the diff is minimal. This should help with future upgrades. So the diff here for templates is big but comparing with upstream the changes are small and isolated

The buildslave configuration was updated to also install sqlite-dev so that we can run the tests.

The addStep warning are there, but I will work in a separate branch to get rid of them.

While working on this I found a bug with the countFailedTests helper as it was crashing if the output has no test result... for example when the test failed before running trial

How to test

I have tested this on my vagrant.

This PR is on top of #204 as there I have fixed the braid state for the vagrant VM. So first go and review and merge #204 :)

Here are the commands I used

fab config.vagrant buildbot.stop
fab config.vagrant buildbot.update
fab config.vagrant buildbot.start
fab config.vagrant buildslave.stop
fab config.vagrant buildslave.update
fab config.vagrant buildslave.start

After that you can go at http://172.16.255.140:8080/ and trigger a few tests

I have tested it on linux.

I think that we should deploy it and then see if we get any errors or regression.

[hawkowl]

This is used by the buildslaves; the workers and master still communicate over PB.

[adiroiban]

True. Thanks.

I have updated it and made a ticket in Twisted as this smells bad to me... we are monkey patching Twisted :)

[adiroiban]

Thanks for the review. Ready for another round :)

[tomprince]

We don't want any of these pages. Most of them don't have any interesting information, and at least one of them used to cause our buildmaster to crash.

[adiroiban]

I am doing this so that the diff will be minimal ... and I hope that will make future updated easier to follow.

I can remove them if you think that they are a big annoyance

[tomprince]

I've made a few comments, but I haven't actually tested anything.

Some changes from the webstatus templates were reverted so that the diff is minimal.

While this is a good idea in theory, the upstream templates have links to a bunch of things that aren't useful for twisted's buildbot, or that we have more useful versions of. I think we should keep our more minimal templates instead. When I was writing the templates we have now, I had two things in mind:

• getting rid of useless links
• not worrying to much about generality, i.e. removing conditionals that always or never apply to our instance, when I was touching code in the conditional.

[adiroiban]

Thanks for the review.

I have reverted some changes to remove unwatented links, but I still tried to keep the diff to a minimum.

Comments were added to talk about the changes.

Here is how the root/start page looks now.

It has the top navigation links and you can see how the look here and in all the other pages.

[glyph]

Please deploy this. We don't have CI for our own buildbot fork, so we don't really have any idea whether it works. Let's get on upstream ASAP and if we start having problems, properly file bugs :)

[adiroiban]

It was merge in 203-simple-pyflakes-builder ... will merge to master :)