Jump to conversation
Unresolved conversations (4)
@glyph glyph Jul 2, 2019
Thanks for changing the bootstrapping as well! One interesting question might be how to configure the filters on this predicate without having to put in a whole custom `BOOTSTRAP`. For a future change, perhaps.
ampoule/main.py
glyph ldanielburr
@glyph glyph Jul 2, 2019
If you put the `log` object onto `AMPChild`, and then do `self.log.info`, this type of namespacing comes along for free. Is this a feature you knew about but didn't want to use, or just something that wasn't clearly documented enough?
Outdated
ampoule/child.py
ldanielburr glyph
@glyph glyph Jul 2, 2019
This should be a single log message as well.
Outdated
ampoule/pool.py
@glyph glyph Jul 2, 2019
Would you mind putting this together into one big log message, rather than spreading it out across a whole bunch of different ones? Conceptually, what's happening here is a dump of stats at a particular moment in time; they should all be associated with each other. The repeated logging calls were just there trying to get the message to format in a particular way, which shouldn't be the log emitter's concern.
Outdated
ampoule/pool.py
Resolved conversations (0)