Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generated file is not compatible with black #55

Closed
moshez opened this issue Jul 27, 2020 · 3 comments · Fixed by #60
Closed

Auto generated file is not compatible with black #55

moshez opened this issue Jul 27, 2020 · 3 comments · Fixed by #60

Comments

@moshez
Copy link

moshez commented Jul 27, 2020

Is it possible to either make it compatible or have a --black-compatible explicit flag?

(I redacted the name of the internal project below, everything else is copy/paste.)

$ black src/
reformatted /Users/mzadka/src/<REDACTED>/src/<REDACTED>/_version.py
All done! ✨ 🍰 ✨
1 file reformatted, 12 files left unchanged.
$ git diff
diff --git a/src/<REDACTED>/_version.py b/src/<REDACTED>/_version.py
index a4efef1..1cc8fa1 100644
--- a/src/<REDACTED>/_version.py
+++ b/src/<REDACTED>/_version.py
@@ -7,5 +7,5 @@ Provides <REDACTED> version information.
 
 from incremental import Version
 
-__version__ = Version('<REDACTED>', 20, 7, 1)
+__version__ = Version("<REDACTED>", 20, 7, 1)
 __all__ = ["__version__"]
@adiroiban
Copy link
Member

+1 for making it compatible by default without any flag.

@rodrigc
Copy link
Contributor

rodrigc commented Sep 24, 2020

Black was enabled by default for formatting the code in Twisted core: https://twistedmatrix.com/pipermail/twisted-python/2020-September/065220.html

So I think making incremental compatible with black (with no special flags) is a fine thing to do

@rodrigc
Copy link
Contributor

rodrigc commented Oct 4, 2020

@moshez can you try this branch: #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants