Add postrelease support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ There's one pyflakes error, could you squash that? The python 3.3 one is unrelated, I'll fix that on another branch. |
1 similar comment
|
✨ There's one pyflakes error, could you squash that? The python 3.3 one is unrelated, I'll fix that on another branch. |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
+ Coverage 96.46% 96.86% +0.4%
=========================================
Files 5 5
Lines 650 733 +83
Branches 62 68 +6
=========================================
+ Hits 627 710 +83
Misses 11 11
Partials 12 12
Continue to review full report at Codecov.
|
|
Ah, right, yes. I've sorted out the pyflakes error. |
glyph
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat related to #29.
My own motivation is that we have a temporary local fork of an old version of Twisted in Launchpad, currently versioned
13.0.0-p2, and as part of trying to convert from buildout to pip (which is a prerequisite for upgrading to a modern Twisted, for tedious reasons) I discovered that the version we have isn't PEP 440-compliant. That caused me to look into whether Twisted's current versioning code supported PEP 440 postreleases, and discovered that it doesn't; hence this PR.