Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the output of incremental compatible with black formatting tool #60

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Make the output of incremental compatible with black formatting tool #60

merged 3 commits into from
Oct 19, 2020

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Oct 4, 2020

Fixes #55

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files           5        5           
  Lines         733      733           
  Branches       68       68           
=======================================
  Hits          710      710           
  Misses         11       11           
  Partials       12       12           
Impacted Files Coverage Δ
src/incremental/tests/test_update.py 100.00% <ø> (ø)
src/incremental/update.py 98.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da39362...bd18675. Read the comment docs.

@wsanchez
Copy link
Member

This PR does a lot more than the header; making incremental use black itself is not related to making incremental's output compatible with black.

Given that making incremental's output compatible with black is important to clients, I think it would be important to do just that in a PR, so that we can document that change independently.

.travis.yml Outdated Show resolved Hide resolved
@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 12, 2020

This PR does a lot more than the header; making incremental use black itself is not related to making incremental's output compatible with black.

Given that making incremental's output compatible with black is important to clients, I think it would be important to do just that in a PR, so that we can document that change independently.

OK, I removed all parts of the PR which formats the incremental code itself with black.
This PR just contains the changes which make the output black compatible

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 12, 2020

I've moved all patches which reformats the incremental tree with black to #64

@rodrigc rodrigc merged commit fdfe7f6 into twisted:master Oct 19, 2020
@rodrigc rodrigc deleted the black-compatible branch October 19, 2020 03:08
@rodrigc rodrigc mentioned this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generated file is not compatible with black
2 participants