Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix dev, rc, and post with "." to make compatible with PEP440 #62

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Prefix dev, rc, and post with "." to make compatible with PEP440 #62

merged 2 commits into from
Oct 14, 2020

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Oct 4, 2020

Fixes #38

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files           5        5           
  Lines         733      733           
  Branches       68       68           
=======================================
  Hits          710      710           
  Misses         11       11           
  Partials       12       12           
Impacted Files Coverage Δ
src/incremental/tests/test_version.py 100.00% <ø> (ø)
src/incremental/__init__.py 87.19% <100.00%> (ø)
src/incremental/tests/test_update.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bcb51...8a92d7b. Read the comment docs.

Copy link
Member

@wsanchez wsanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 12, 2020

Thanks. I don't have permissions to merge this, so can't move forward.

@rodrigc rodrigc merged commit da39362 into twisted:master Oct 14, 2020
@rodrigc rodrigc deleted the pep440-compatible branch October 14, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental --dev is not fully pep440 compliant
2 participants