fix tests, now they all run, pep8-ed test_ldiftree #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore in .gitignore
…sting ignore in .gitignore" This reverts commit 47d0771.
|
That's a messy history.. I'd recommend rebasing, and keeping pure whitespace changes separate from changes to behavior. |
|
That is after a rebase... this was with a lengthy conversation with hawkowl. We was so kind as to set up a travis-ci for this. At this point, what I can do is just nuke this merge request and my branch (after making diff patch), then create a new branch/merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bit of refactoring of the ldaptor/test/test_ldiftree.py so now that those 3 failing tests now pass. This opened up 50 additional tests that also pass.
It looks like the code was written around python 2.4 so I cleaned it up a bit, removed deprecated 'sets' and pep8-ed as much as I could.
I recommend that after this commit, we branch with 0.54.0 and tag for release.
Update: less pep8-ed then before to keep with twisted standards.