GitHub issue #11: Nevow should handle interrupted HTTP responses. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,6 +131,19 @@ def renderHTTP(self, ctx): | |||
| return self.renderResource(Res1(), 'bar').addCallback( | |||
| lambda result: self.assertEquals(result, 'world')) | |||
|
|
|||
| def test_connectionLost(self): | |||
There was a problem hiding this comment.
Could you please add a docstring for this test?
|
Docstring has been added. |
Merged
|
I made some more coding standard-type changes: #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nowhere in Nevow to attach an error handler for
Request.finish()being called after a connection has been dropped, because the call is inside Nevow itself. A web application that uses redirection will get an error every time it does any asynchronous rendering, because the redirection happens before rendering finishes. This patch has Nevow catch and ignore the error.