Update examples to work on Python 3 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 20 20
Lines 1738 1738
Branches 154 154
=======================================
Hits 1678 1678
Misses 39 39
Partials 21 21Continue to review full report at Codecov.
|
twm
force-pushed
the
py3-examples
branch
2 times, most recently
from
d4c7725
to
961a38c
Compare
|
I do wish we had better automated coverage of examples, but manually testing, this looks like a great upgrade. I didn't even know about |
|
(Just waiting for CI to finish; will merge when it does.) |
As pointed out in twisted#151 the basic_post.py example didn't work in Python 3. This also updates the others to be source compatible.
|
Rebased again. |
|
@glyph, anybody: Merge please? |
|
Looks good to me. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #151 the basic_post.py example didn't work in Python 3. This also updates the others to be source compatible.