Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTesting custom endpoint #177
Conversation
tomprince
and others
added some commits
Mar 14, 2017
This was referenced Mar 27, 2017
| @implementer(IAgentEndpointFactory) | ||
| @attr.s | ||
| class _EndpointFactory(object): |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Since this has conflicts, can you resolve? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
Mar 27, 2017
Codecov Report
Merging #177 into master will increase coverage by
0.01%.
The diff coverage is100%.
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 96.55% 96.56% +0.01%
==========================================
Files 20 20
Lines 1740 1749 +9
Branches 154 155 +1
==========================================
+ Hits 1680 1689 +9
Misses 39 39
Partials 21 21| Impacted Files | Coverage Δ | |
|---|---|---|
| src/treq/testing.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 47453b1...275f6af. Read the comment docs.
codecov
commented
Mar 27, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 96.55% 96.56% +0.01%
==========================================
Files 20 20
Lines 1740 1749 +9
Branches 154 155 +1
==========================================
+ Hits 1680 1689 +9
Misses 39 39
Partials 21 21
Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
glyph
Mar 27, 2017
Member
Since you're noting a limitation with respect to HTTPS, please file an issue for supporting it in the future and link to it. Luckily HTTPS support was previously wrong too (requests will return an incorrect isSecure() result).
|
Since you're noting a limitation with respect to HTTPS, please file an issue for supporting it in the future and link to it. Luckily HTTPS support was previously wrong too (requests will return an incorrect |
glyph
approved these changes
Mar 27, 2017
If you can fix that last comment and get a passing CI run I think we are good to merge on this. Thanks for working on this very important functionality :). How soon can we do a release?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
glyph
Mar 27, 2017
Member
Oops, my comment about HTTPS above is bunk, we already handle that but it's not visible in the diff. Carry on!
|
Oops, my comment about HTTPS above is bunk, we already handle that but it's not visible in the diff. Carry on! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Closing and re-opening in an attempt to wake up Travis. |
markrwilliams
closed this
Mar 27, 2017
markrwilliams
reopened this
Mar 27, 2017
markrwilliams
merged commit 2e7a95e
into
twisted:master
Mar 27, 2017
markrwilliams
deleted the
markrwilliams:testing-custom-endpoint
branch
Mar 27, 2017
markrwilliams
referenced this pull request
Mar 27, 2017
Closed
RequestTraversalAgent broken with Twisted 17.1.0 (MemoryReactor AttributeError) #164
added a commit
to markrwilliams/treq
that referenced
this pull request
Mar 28, 2017
added a commit
that referenced
this pull request
Mar 28, 2017
markrwilliams commentedMar 27, 2017
A non-WIP version of #175. Thanks, @tomprince !