Attempt to aggressively close connections to prevent spurious unclean reactor errors. #22

Merged
merged 2 commits into from Jan 29, 2013

Conversation

Projects
None yet
2 participants
@dreid
Contributor

dreid commented Jan 23, 2013

No description provided.

@Julian

This comment has been minimized.

Show comment Hide comment
@Julian

Julian Jan 23, 2013

Member

Maybe this hack could / should be shipped somewhere exposed in treq?

Users testing treq applications are going to want to do it too.

Member

Julian commented Jan 23, 2013

Maybe this hack could / should be shipped somewhere exposed in treq?

Users testing treq applications are going to want to do it too.

@dreid

This comment has been minimized.

Show comment Hide comment
@dreid

dreid Jan 28, 2013

Contributor

I don't know that I think this should be a thing exposed by treq.

I definitely don't think exposing it to users should block this PR because, fixing these integration tests is already blocking other PRs.

Which brings me to the point of this PR. Is there a cleaner way to do it?

Contributor

dreid commented Jan 28, 2013

I don't know that I think this should be a thing exposed by treq.

I definitely don't think exposing it to users should block this PR because, fixing these integration tests is already blocking other PRs.

Which brings me to the point of this PR. Is there a cleaner way to do it?

@dreid

This comment has been minimized.

Show comment Hide comment
@dreid

dreid Jan 29, 2013

Contributor

Merging because @hynek says this fixes #21

Contributor

dreid commented Jan 29, 2013

Merging because @hynek says this fixes #21

dreid added a commit that referenced this pull request Jan 29, 2013

Merge pull request #22 from dreid/clean-integration-tests
Attempt to aggressively close connections to prevent spurious unclean reactor errors.

@dreid dreid merged commit a60c38b into master Jan 29, 2013

1 check passed

default The Travis build passed
Details
@Julian

This comment has been minimized.

Show comment Hide comment
@Julian

Julian Jan 29, 2013

Member

Yes I definitely didn't mean to hold up merging this.

I have to play with it a bit more, if I come up with something I'll open anothe ticket.

Member

Julian commented Jan 29, 2013

Yes I definitely didn't mean to hold up merging this.

I have to play with it a bit more, if I come up with something I'll open anothe ticket.

pawelmhm pushed a commit to pawelmhm/treq that referenced this pull request Nov 4, 2016

Merge pull request #22 from alex/no-mirrors
Removed the usage of mirrors in ``pip install`` from the travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment