Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support coverage -p #277

Merged
merged 6 commits into from Dec 29, 2021
Merged

support coverage -p #277

merged 6 commits into from Dec 29, 2021

Conversation

glyph
Copy link
Member

@glyph glyph commented Mar 24, 2020

No description provided.

@glyph glyph requested a review from twm Mar 24, 2020
Copy link
Contributor

@twm twm left a comment

I'm all for this feature, but please do it at the source!

Thanks!

.travis.yml Outdated
@@ -80,6 +80,7 @@ script:
- tox

after_success:
- coverage combine
Copy link
Contributor

@twm twm Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update and run tox2travis.py instead of editing this file.

@glyph glyph requested a review from twm Apr 17, 2020
@glyph
Copy link
Member Author

@glyph glyph commented Apr 17, 2020

Feedback addressed.

Copy link
Contributor

@twm twm left a comment

Thanks for continuing to work on this!

.travis.yml Outdated
@@ -8,7 +8,7 @@ cache: pip
jobs:
include:
- python: "3.8"
env: TOXENV=towncrier,twine,check-manifest,flake8,docs
env: TOXENV=twine,check-manifest,flake8,docs,coverage-report
Copy link
Contributor

@twm twm Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preceding envs won't generate any coverage. Shouldn't tox2travis.py filter out coverage-report? This is causing the build to fail:

coverage-report run-test-pre: PYTHONHASHSEED='4152157654'
coverage-report run-test: commands[0] | coverage combine
No data to combine
ERROR: InvocationError for command /home/travis/build/twisted/treq/.tox/coverage-report/bin/coverage combine (exited with code 1)

tox.ini Outdated
@@ -58,3 +57,9 @@ commands =
changedir = docs
commands =
sphinx-build -b html . html

[testenv:coverage-report]
depends = pypy,py27,py35,py36,py37
Copy link
Contributor

@twm twm Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't realize you can depend on factors alone!

@glyph glyph requested a review from twm Dec 28, 2021
twm
twm approved these changes Dec 29, 2021
Copy link
Contributor

@twm twm left a comment

:shipit: Thank you!

@twm twm enabled auto-merge Dec 29, 2021
@twm twm merged commit 3d33835 into master Dec 29, 2021
26 of 27 checks passed
@twm twm deleted the parallel-coverage branch Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants