support coverage -p
#277
Merged
support coverage -p
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twm
requested changes
Mar 25, 2020
.travis.yml
Outdated
| @@ -80,6 +80,7 @@ script: | |||
| - tox | |||
|
|
|||
| after_success: | |||
| - coverage combine | |||
There was a problem hiding this comment.
Please update and run tox2travis.py instead of editing this file.
|
Feedback addressed. |
twm
requested changes
Apr 18, 2020
.travis.yml
Outdated
| @@ -8,7 +8,7 @@ cache: pip | |||
| jobs: | |||
| include: | |||
| - python: "3.8" | |||
| env: TOXENV=towncrier,twine,check-manifest,flake8,docs | |||
| env: TOXENV=twine,check-manifest,flake8,docs,coverage-report | |||
There was a problem hiding this comment.
The preceding envs won't generate any coverage. Shouldn't tox2travis.py filter out coverage-report? This is causing the build to fail:
coverage-report run-test-pre: PYTHONHASHSEED='4152157654'
coverage-report run-test: commands[0] | coverage combine
No data to combine
ERROR: InvocationError for command /home/travis/build/twisted/treq/.tox/coverage-report/bin/coverage combine (exited with code 1)
tox.ini
Outdated
| @@ -58,3 +57,9 @@ commands = | |||
| changedir = docs | |||
| commands = | |||
| sphinx-build -b html . html | |||
|
|
|||
| [testenv:coverage-report] | |||
| depends = pypy,py27,py35,py36,py37 | |||
There was a problem hiding this comment.
Cool, I didn't realize you can depend on factors alone!
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.