Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a single view of all pending reviews for Twisted #11

Open
adiroiban opened this issue Mar 16, 2015 · 5 comments
Open

Have a single view of all pending reviews for Twisted #11

adiroiban opened this issue Mar 16, 2015 · 5 comments

Comments

@adiroiban
Copy link
Member

We do have https://twistedmatrix.com/trac/report/25

but we also have twisted-infra/* and twisted/twistedchecker and twitsted/twisted-dev-tools which gets PRs

For GitHub I was able to create this query:

https://github.com/pulls?q=is%3Aopen+is%3Apr+repo%3Atwisted%2Ftwistedchecker+repo%3Atwisted%2Ftwisted-dev-tools+user%3Atwisted-infra+

which is in fact

is:open is:pr repo:twisted/twistedchecker repo:twisted/twisted-dev-tools user:twisted-infra 

We can argue that twistedchecker and twisted-dev-tools should be part of twisted main repo as I have no idea who would want to use them outside of twisted.

In this case the filter would be much easier and we would only have twisted-infra reviews


I would like to see all these PR in a single place, for example here https://twistedmatrix.com/trac/report/25

I am thinking of updating the Trac theme so that when the url is report/25 it will do an Ajax request and insert those issues into the report with links to github.

@hynek What do you think?

In this way PR as twisted-infra/t-web#7 should be much visible.

Maybe this should be filled in twisted-infra/trac but I feel that this is an important dev tool :)

@hynek
Copy link
Member

hynek commented Mar 16, 2015

My uninformed questions would be:

  • there is a JSON-endpoint in the GitHub API that would allow us to do that, right?
  • has trac something similar?

Having those two would make it trivial to implement…

@adiroiban
Copy link
Member Author

GitHub API is great - and we can use Issues search for that - https://developer.github.com/v3/search/#search-issues

has trac something similar?

I don't understand the question...but I think that GitHub API is enough and we can fill the Trac report either on server or client side.

My idea was to do it on client side to reduce load on the server

@hynek
Copy link
Member

hynek commented Mar 16, 2015

My question was whether Trac has a search API or whether we have to parse HTML output of the report if we want to create a dashboard that contains both Trac and GitHub issues.

@adiroiban
Copy link
Member Author

There is Trac XML-PRC api but I don't know if we want to enable it and I don't think that we need it.

I was just thinking to inject those links into the Trac report page https://twistedmatrix.com/trac/report/25

@tomprince
Copy link
Contributor

There is an AMP ednpoint that talks to trac; although perhaps it isn't worth the effort to continue to maintain it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants