Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for twisted.internet.task #10155

Closed
twisted-trac opened this issue Mar 27, 2021 · 6 comments
Closed

Add type hints for twisted.internet.task #10155

twisted-trac opened this issue Mar 27, 2021 · 6 comments

Comments

@twisted-trac
Copy link

twisted-trac commented Mar 27, 2021

wsanchez's avatar @wsanchez reported
Trac ID trac#10155
Type enhancement
Created 2021-03-27 19:35:26Z
Branch https://github.com/twisted/twisted/tree/1570

Add type hints for twisted.internet.task

Searchable metadata
trac-id__10155 10155
type__enhancement enhancement
reporter__wsanchez wsanchez
priority__normal normal
milestone__None None
branch__1570 1570
branch_author__ 
status__reopened reopened
resolution__None None
component__core core
keywords__None None
time__1616873726559072 1616873726559072
changetime__1627055790806379 1627055790806379
version__None None
owner__wsanchez wsanchez

@twisted-trac
Copy link
Author

twisted-trac commented Apr 2, 2021

wsanchez's avatar @wsanchez commented

PR: #1570

@twisted-trac
Copy link
Author

twisted-trac commented May 10, 2021

wsanchez's avatar @wsanchez set owner to @wsanchez

@twisted-trac
Copy link
Author

twisted-trac commented May 10, 2021

wsanchez's avatar @wsanchez set status to closed

@twisted-trac
Copy link
Author

twisted-trac commented Jul 23, 2021

adiroiban's avatar @adiroiban set status to reopened

Was reverted due to #10235

@twisted-trac
Copy link
Author

twisted-trac commented Jul 23, 2021

wsanchez's avatar @wsanchez commented

Just to clarify… it looks like #10235 was addressed by PR 1367, which reverted part of this ticket, but not all of it.

In particular, it reverts a change related to the use of the now built into supported Python's __qualname__ attribute on callables, because Python only provides that for functions, and so callables like classes broke.

Jonathan de Jong comments in the PR that this is easily fixed for classes. That comment wasn't replied to prior to merging, perhaps because this was just being done to get the release moving.

All that said, this was an opportunistic cleanup of code, and the rest of this ticket was left intact, I'm inclined to close this again. Sound right?

@exarkun
Copy link
Member

exarkun commented Aug 18, 2022

The DelayedCall __repr__ changes don't seem strongly related to the task of "Add type hints for twisted.internet.task" so I am closing this again.

#6066 which was closed on the basis of exactly the reverted revision should still be open, though, and I have re-opened it since it was left closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants