Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitter chat tab to documentation #10245

Closed
twisted-trac opened this issue Aug 1, 2021 · 2 comments
Closed

Add gitter chat tab to documentation #10245

twisted-trac opened this issue Aug 1, 2021 · 2 comments

Comments

@twisted-trac
Copy link

twisted-trac commented Aug 1, 2021

adiroiban's avatar @adiroiban reported
Trac ID trac#10245
Type enhancement
Created 2021-08-01 12:33:06Z

To get something like the "Open Chat" bottom right tab from www.starlette.io

use https://sidecar.gitter.im/

we might need to copy the JS file and host it as a static file.

And add a custom JS.

https://docs.readthedocs.io/en/stable/guides/adding-custom-css.html

Searchable metadata
trac-id__10245 10245
type__enhancement enhancement
reporter__adiroiban adiroiban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__review review
time__1627821186723545 1627821186723545
changetime__1627841716694678 1627841716694678
version__None None
owner__Adi_Roiban__adiroiban_____ Adi Roiban <adiroiban@...>

@twisted-trac
Copy link
Author

twisted-trac commented Aug 1, 2021

adiroiban's avatar @adiroiban commented

PR at #1649

@twisted-trac
Copy link
Author

twisted-trac commented Aug 1, 2021

adiroiban's avatar @adiroiban set owner to @adiroiban
@adiroiban set status to closed

In changeset 34f3d8f

#!CommitTicketReference repository="" revision="34f3d8f8c6f51772eaed92a89257ea011e9a818d"
Merge pull request #1649 from twisted/10245-gitter-docs-integartion

Author: adiroiban
Reviewer: graingert 
Fixes: ticket:10245

Add Gitter sidecar chat button to documentation pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants