Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
#1678 became a problem because the relevant test cases were skipped on all platforms due to code with this pattern:
skipFoo = "" # Intent: don't skip
skipFoo = "don't have the thing"
skip = skipFoo
However, the empty string here still skips. None is the sentinel value to not skip. There are a bunch of places this pattern appears in the codebase.
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
Thanks for the review Glyph!
No branches or pull requests