Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTransferServer.packet_CLOSE raises AttributeError for non-open handle #10293

Closed
twisted-trac opened this issue Jan 21, 2022 · 6 comments
Closed

Comments

@twisted-trac
Copy link

twisted-trac commented Jan 21, 2022

exarkun's avatar @exarkun reported
Trac ID trac#10293
Type enhancement
Created 2022-01-21 21:37:41Z

When FileTransferServer tries to process a CLOSE request with a handle identifier that is not open it tries to call self._ebClose. There is no such attribute so this raises an AttributeError and never responds to the request.

Searchable metadata
trac-id__10293 10293
type__enhancement enhancement
reporter__exarkun exarkun
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__conch conch
keywords__None None
time__1642801061249338 1642801061249338
changetime__1643039762895677 1643039762895677
version__None None
owner__exarkun exarkun

@twisted-trac
Copy link
Author

twisted-trac commented Jan 21, 2022

exarkun's avatar @exarkun commented

OpenSSH (if I am even looking at the right codebase) seems to return ENOENT in this case:

https://github.com/openssh/openssh-portable/blob/68085066b6bad43643b43f5957fcc5fd34782ccd/sftp-server.c#L447-L464

@twisted-trac
Copy link
Author

twisted-trac commented Jan 24, 2022

exarkun's avatar @exarkun commented

#1685

@twisted-trac
Copy link
Author

twisted-trac commented Jan 24, 2022

wsanchez's avatar @wsanchez set status to closed

reviewed

@twisted-trac
Copy link
Author

twisted-trac commented Jan 24, 2022

wsanchez's avatar @wsanchez set status to reopened

@twisted-trac
Copy link
Author

twisted-trac commented Jan 24, 2022

wsanchez's avatar @wsanchez set owner to @exarkun
@wsanchez set status to new

@twisted-trac
Copy link
Author

twisted-trac commented Jan 24, 2022

exarkun's avatar @exarkun set status to closed

#1685 merged in a033c84

I followed the guidance for merge commit message but this ticket did not auto-close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants