Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted.python.test.test_release.CheckNewsfragmentScriptTests.test_diffFromTrunkNoNewsfragments fails in some environments #10299

Closed
twisted-trac opened this issue Jan 28, 2022 · 4 comments

Comments

@twisted-trac
Copy link
Collaborator

@twisted-trac twisted-trac commented Jan 28, 2022

exarkun's avatar @exarkun reported
Trac ID trac#10299
Type defect
Created 2022-01-28 21:02:50Z

CheckNewsfragmentScriptTests.setUp almost completely wipes the environment then the tests try to run git as a child process. This means the runCommand calls in the test methods have to find git with no PATH set which is unreliable at best.

Searchable metadata
trac-id__10299 10299
type__defect defect
reporter__exarkun exarkun
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1643403770519143 1643403770519143
changetime__1643414735060828 1643414735060828
version__None None
owner__exarkun exarkun

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 28, 2022

exarkun's avatar @exarkun commented

#1688

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 28, 2022

wsanchez's avatar @wsanchez set owner to @exarkun

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 28, 2022

wsanchez's avatar @wsanchez commented

reviewed

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 29, 2022

exarkun's avatar @exarkun set status to closed

Fix merged in c2084b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants