Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LoopingCall tests in twisted.test.test_task encode implementation details of Clock #11679

exarkun opened this issue Sep 21, 2022 · 0 comments · Fixed by #11680


Copy link

exarkun commented Sep 21, 2022

As reported in #5962, Clock and the real reactor differ in their handling of callLater(0, ...). Unfortunately the LoopingCall tests in twisted.test.test_task encode a dependency on the Clock behavior so they only demonstrate that LoopingCall has some behavior when used with a broken reactor.

I have a fix for #5962 but I don't want to complicate its PR with a lot of subtle changes to test suites for other units. So, in preparation for landing that work, let's fix these tests to have the minimum possible dependency on Clock's quirks.

exarkun added a commit that referenced this issue Sep 22, 2022
Remove some assumptions on Clock misbehaviors from the LoopingCall tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging a pull request may close this issue.

1 participant