Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a lot of signal-handling code in twisted/internet/base.py when it could be near other signal handling code in twisted/internet/_signals.py #11702

Closed
exarkun opened this issue Oct 5, 2022 · 0 comments · Fixed by #11703
Closed

There is a lot of signal-handling code in twisted/internet/base.py when it could be near other signal handling code in twisted/internet/_signals.py #11702

exarkun opened this issue Oct 5, 2022 · 0 comments · Fixed by #11703

Comments

@exarkun
Copy link
Member

exarkun commented Oct 5, 2022

If the signal-handling code were all in one place then the various reactor implementation modules would each be a little bit more focused and so easier to understand and maintain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11702 move some signal code exarkun/twisted
1 participant
@exarkun