Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Port in twisted\internet\_glibbase #9660

Closed
twisted-trac opened this issue Jun 17, 2019 · 9 comments
Closed

Python 3 Port in twisted\internet\_glibbase #9660

twisted-trac opened this issue Jun 17, 2019 · 9 comments

Comments

@twisted-trac
Copy link
Collaborator

@twisted-trac twisted-trac commented Jun 17, 2019

doadin's avatar @doadin reported
Trac ID trac#9660
Type defect
Created 2019-06-17 18:29:45Z

Hello so, calling simulate() results in this error in python 3:

  File "C:\Python\Python37\lib\site-packages\twisted\internet\_glibbase.py", line 385, in simulate
    timeout = min(self.timeout(), 0.01)
TypeError: '<' not supported between instances of 'float' and 'NoneType'

suggestion: #1679

Searchable metadata
trac-id__9660 9660
type__defect defect
reporter__doadin doadin
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1560796185779425 1560796185779425
changetime__1647602141680220 1647602141680220
version__None None
owner__None None

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Nov 22, 2019

doadin's avatar @doadin set owner to @hawkowl

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Dec 21, 2019

doadin's avatar @doadin set owner to @doadin

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Dec 21, 2019

doadin's avatar @doadin removed owner

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 9, 2020

twm's avatar @twm commented

I reviewed here: #1159 (review)

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 12, 2020

doadin's avatar @doadin commented

Replying to Tom Most:

I reviewed here: #1159 (review)

Sorry im going to have to admit defeat on this one.

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 3, 2022

doadin's avatar @doadin commented

Hello, so I got back into development that led me to make this ticket in the first place now that I have more time. This was reviewed before, since this hasn't been fixed in 3 years I thought id give it a go again. I made a few changes since the last review. It has all the same changes suggested in review before but improved the test code a little bit. Not sure what else it needs.

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Jan 3, 2022

glyph's avatar @glyph commented

Thank you for checking back in on this after all this time!

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Mar 18, 2022

yan12125's avatar @yan12125 commented

There is a typo in a newly-added test, and I created a PR to fix it: #1705

@twisted-trac
Copy link
Collaborator Author

@twisted-trac twisted-trac commented Mar 18, 2022

exarkun's avatar @exarkun set status to closed

Fix merged in 9045ef7

There is a typo in a newly-added test, and I created a PR to fix it: ​#1705

Thanks for noticing this. Please see the Twisted contributor documentation (and the GitHub PR template) for guidance in getting this fix merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant