Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted.protocols.test.test_tls not run on CI systems #9944

Open
twisted-trac opened this issue Aug 21, 2020 · 5 comments
Open

twisted.protocols.test.test_tls not run on CI systems #9944

twisted-trac opened this issue Aug 21, 2020 · 5 comments

Comments

@twisted-trac
Copy link

twisted-trac commented Aug 21, 2020

exarkun's avatar @exarkun reported
Trac ID trac#9944
Type defect
Created 2020-08-21 15:56:21Z

According to a recent coveralls.io report:

https://coveralls.io/builds/32817266/source?filename=src/twisted/protocols/test/test_tls.py

twisted.protocols.test.test_tls is essentially completely unexecuted across coverage-gathering CI jobs.

This appears to be due to a change in pyOpenSSL 19.1.0 which removed ConnectionType. The whole test_tls module is skipped if this can't be imported.

This suggests the module may have been skipped on CI since sometime in 2019.

Searchable metadata
trac-id__9944 9944
type__defect defect
reporter__exarkun exarkun
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__None None
time__1598025381182652 1598025381182652
changetime__1626935726362504 1626935726362504
version__None None
owner__adiroiban adiroiban

@twisted-trac
Copy link
Author

twisted-trac commented Nov 25, 2020

adiroiban's avatar @adiroiban commented

Tentative PR at #1484

@twisted-trac
Copy link
Author

twisted-trac commented Dec 25, 2020

adiroiban's avatar @adiroiban commented

We have a PR... we did our best to enable the tests.

Most of the tests are green without any main code changes... only the test code was updated.

For ALPN I ran manual tests and it works.

I think that this will be merged soon... but I don't think it's a release blocker.

@twisted-trac
Copy link
Author

twisted-trac commented Jan 25, 2021

exarkun's avatar @exarkun set owner to @adiroiban

@twisted-trac
Copy link
Author

twisted-trac commented Mar 21, 2021

adiroiban's avatar @adiroiban removed owner

@twisted-trac
Copy link
Author

twisted-trac commented Jul 22, 2021

glyph's avatar @glyph set owner to @adiroiban

Hey Adi,

Thanks for doing this, but it looks like we have merge conflicts. I'm trying to prune the review queue down to immediately actionable stuff. Can you address those and resubmit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants