9441 conch public key

[markrwilliams]

Contributor Checklist:

• There is an associated ticket in Trac. https://twistedmatrix.com/trac/ticket/9441
• The changes pass minimal style checks (see: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#GettingYourPatchAccepted )
• I have created a newsfragment in src/twisted/newsfragments/ (see: https://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles )
• I have updated the automated tests.

[codecov]

Codecov Report

Merging #1010 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            trunk    #1010      +/-   ##
==========================================
+ Coverage   91.88%   91.89%   +<.01%     
==========================================
  Files         842      842              
  Lines      150197   150198       +1     
  Branches    13138    13137       -1     
==========================================
+ Hits       138008   138018      +10     
+ Misses      10096    10091       -5     
+ Partials     2093     2089       -4

[adiroiban]

Thanks for fixing this.

Looks good to merge.

I have reverted the fix and run only the tests and I can see a failure.

In terms of testing, I was expecting to see another test with dedicated docstring like

def test_publicAlreadyPublic():
    """
    For public keys, it returns the same instance.
    """
    publicRSAKey = keys.Key.fromString(keydata.publicRSA_openssh)
    self.assertIs(publicRSAKey, publicRSAKey.public())

[wiml]

@adiroiban : I think that having public_key() return self is only an implementation detail; at least, that's what the documentation says. I don't think the unit tests should be asserting something that the documentation explicitly says you shouldn't rely on.

[adiroiban]

I don't think the unit tests should be asserting something that the documentation explicitly says you shouldn't rely on.

True.. Thanks. Merged