[9445] Re-enable macOS on circleCI. #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
changed the title
glyph
reviewed
Sep 1, 2018
There was a problem hiding this comment.
Review comments on Trac: https://twistedmatrix.com/trac/ticket/9445#comment:3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
See https://twistedmatrix.com/trac/ticket/9445
This re-enabled macOS builds on circleCI after circelCI donated more build times for Twisted.
With macOS on CircleCI we can run macOS tests from branches which don't belong to Twisted repo and which are not run on Buildbot.
Changes
I have now enabled the macOS builds only after static checkers and documentation is green.
I hope that this can reduce the time we use macOS on circleCI
How to test
Check that this branch has macOS build https://circleci.com/gh/twisted/workflows/twisted
One build for this PR https://circleci.com/workflow-run/385ec102-6182-407f-9daa-ba3b4406377c