9480-Renamed samesite to sameSite in t.w.h.Request.addCookie. #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improved its API documentation. Fixes: twisted#9479 twisted#9480
glyph
approved these changes
Jul 4, 2018
hawkowl
pushed a commit
that referenced
this pull request
Jul 5, 2018
…kie-sameSite Author: evilham Reviewers: glyph Fixes: ticket:9480 Renamed samesite to sameSite in t.w.h.Request.addCookie.
danmaas
added a commit
to spinpunch/twisted
that referenced
this pull request
Jul 13, 2018
* trunk: (85 commits) dev0 Remove extra param from docstring. Remove the offending test entirely, per review Work around txchecker bug Skip CModuleSendmsgTests.test_shortsend update readme full changelog full ver Revert "18.7.0rc1 newsfile" Revert "changelog" changelog don't delete this dir incremental Merge pull request twisted#1036 from evilham/9480-evilham-web-Request-addCookie-sameSite Newsfile Expand HTTPFactory docstring Added newsfragments files for twisted#9479 and twisted#9480. Renamed samesite to sameSite in t.w.h.Request.addCookie. move 2008-2014 changelogs into historic 18.7.0rc1 newsfile ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved its API documentation.
Fixes: https://tm.tl/9479 https://tm.tl/9480
Contributor Checklist:
9479.miscand9480.misc.