/twisted

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9480-Renamed samesite to sameSite in t.w.h.Request.addCookie. #1036

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Reviewers

@glyph glyph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@evilham @glyph @markrwilliams
@evilham
Contributor

evilham commented Jul 4, 2018 •
edited by glyph

Also improved its API documentation.

Fixes: https://tm.tl/9479 https://tm.tl/9480

Contributor Checklist:

  • There is an associated ticket in Trac. #9480 and #9479
  • The changes pass minimal style checks
  • Newsfragment: since this builds upon #9387 which is already listed there, created 9479.misc and 9480.misc.
  • I have updated the automated tests.

evilham added some commits Jul 4, 2018

@evilham
Renamed samesite to sameSite in t.w.h.Request.addCookie. 
Also improved its API documentation.

Fixes: #9479 #9480
Loading status checks…
0dc5dd4
@evilham
Added newsfragments files for #9479 and #9480.
Loading status checks…
3d998ff
@glyph

glyph approved these changes Jul 4, 2018
View changes

LGTM. I don't have enough time to wait for all the CI machinery (mainly the Appveyor rebuild) so I'm approving contingent upon a passing CI run.

@markrwilliams markrwilliams merged commit 27d19e0 into twisted:trunk Jul 5, 2018
30 checks passed

30 checks passed

buildbot/documentation Buildbot test done.
Details
buildbot/fedora26-py2.7 Buildbot test done.
Details
buildbot/fedora26-py2.7-coverage Buildbot test done.
Details
buildbot/fedora26-py3.6 Buildbot test done.
Details
buildbot/fedora26-py3.6-coverage Buildbot test done.
Details
buildbot/fedora27-py2.7 Buildbot test done.
Details
buildbot/fedora27-py2.7-coverage Buildbot test done.
Details
buildbot/fedora27-py3.6 Buildbot test done.
Details
buildbot/fedora27-py3.6-coverage Buildbot test done.
Details
buildbot/osx10.11-py2.7-coverage Buildbot test done.
Details
buildbot/rhel7-py2.7 Buildbot test done.
Details
buildbot/rhel7-py2.7-coverage Buildbot test done.
Details
buildbot/ubuntu14.04-py2.7 Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7 Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-newstyle-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-nodeps Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-nodeps-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5 Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5-asyncio-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5-coverage Buildbot test done.
Details
buildbot/windows7-64-py2.7 Buildbot test done.
Details
buildbot/windows7-64-py2.7-coverage Buildbot test done.
Details
buildbot/windows7-64-py2.7-wheel Buildbot test done.
Details
ci/circleci: documentation Your tests passed on CircleCI!
Details
ci/circleci: pyflakes3 Your tests passed on CircleCI!
Details
ci/circleci: static_checkers Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

hawkowl added a commit that referenced this pull request Jul 5, 2018

@markrwilliams @hawkowl
Merge pull request #1036 from evilham/9480-evilham-web-Request-addCoo… 
…kie-sameSite

Author: evilham

Reviewers: glyph

Fixes: ticket:9480

Renamed samesite to sameSite in t.w.h.Request.addCookie.
Loading status checks…
685f235

danmaas added a commit to spinpunch/twisted that referenced this pull request Jul 13, 2018

@danmaas
Merge branch 'trunk' into spinpunch-dev 
* trunk: (85 commits)
  dev0
  Remove extra param from docstring.
  Remove the offending test entirely, per review
  Work around txchecker bug
  Skip CModuleSendmsgTests.test_shortsend
  update readme
  full changelog
  full ver
  Revert "18.7.0rc1 newsfile"
  Revert "changelog"
  changelog
  don't delete this dir
  incremental
  Merge pull request #1036 from evilham/9480-evilham-web-Request-addCookie-sameSite
  Newsfile
  Expand HTTPFactory docstring
  Added newsfragments files for #9479 and #9480.
  Renamed samesite to sameSite in t.w.h.Request.addCookie.
  move 2008-2014 changelogs into historic
  18.7.0rc1 newsfile
  ...
4667619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment