Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9482 httpfactory docstring #1037

Merged
merged 6 commits into from
Jul 9, 2018
Merged

9482 httpfactory docstring #1037

merged 6 commits into from
Jul 9, 2018

Conversation

twm
Copy link
Contributor

@twm twm commented Jul 5, 2018

Document some undocumented parameters to twisted.web.http.HTTPFactory.

Contributor Checklist:

@codecov
Copy link

codecov bot commented Jul 7, 2018

Codecov Report

Merging #1037 into trunk will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            trunk    #1037     +/-   ##
=========================================
- Coverage   91.84%   91.75%   -0.1%     
=========================================
  Files         844      844             
  Lines      150593   150986    +393     
  Branches    13141    13234     +93     
=========================================
+ Hits       138312   138537    +225     
- Misses      10181    10360    +179     
+ Partials     2100     2089     -11

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great documentation enhancement. Please merge at your convenience!

@twm twm removed the needs-review label Jul 9, 2018
@twm twm merged commit c82a021 into trunk Jul 9, 2018
@twm twm deleted the 9482-httpfactory-docstring branch July 9, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants