[9485] Skip CModuleSendmsgTests.test_shortsend #1038
Conversation
The check on Travis seems to think that the ticket number is a comment.
It is failing like this:
src/twisted/python/test/test_sendmsg.py (80.0%):
413: W9401: (Used for checking comment format issues.), : Comments should begin with one whitespace
Attempt to work around this by removing the # character.
There was a problem hiding this comment.
Thanks for the cleanup.
.misc fragment is perfect :)
Rather than keeping code which is never run ... maybe we should just delete it.
We can copy the test in the ticket details for 9452 to make it easier to find it.
I don't see the point of keeping a test which is always skipped.
I feel that we are abusing the test skip functionality... and we turn it into a .todo thing.
Is ok to skip a test on Windows, as long as it runs on Linux.
At some point, I have cleaned/removed the .todo tests.
The .todo tests were code with time became code which is not maintained.
We can merge it as is, but I prefer to just remove the test and have a clean code.
Thanks!
Codecov Report
@@ Coverage Diff @@
## trunk #1038 +/- ##
==========================================
+ Coverage 91.85% 91.89% +0.04%
==========================================
Files 844 844
Lines 150605 150606 +1
Branches 13142 13142
==========================================
+ Hits 138332 138400 +68
+ Misses 10176 10114 -62
+ Partials 2097 2092 -5 |
|
Thank you @twm, thank you @adiroiban ! |
As discussed on the mailing list. I opted for a .misc newsfile as I don't think this is likely to interest anyone reading the changelog.
Contributor Checklist: