Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9217] Build lots of wheels #1051

Merged
merged 92 commits into from
Mar 16, 2019
Merged

Conversation

altendky
Copy link
Member

@altendky altendky commented Aug 28, 2018

https://twistedmatrix.com/trac/ticket/9217

https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch

Work to do:

  • Storage for Travis artifacts
    • Using Circle for now
  • Get cibuildwheel working on CircleCI for OSX wheels
  • Learn about how Twisted likes to deploy wheels
    • Maybe automate deployment if interested)
      • I did do PyPi deployment from Travis for a project
      • Glyph is interested but I'd suggest a separate PR
    • Automatic deployment will be addressed separately
  • Resolve test failure on twisted.cred.test.test_strcred.SSHCheckerTests.test_isChecker ([9217] Build lots of wheels #1051 (comment))
    • Passing now
  • Use a released version of cibuildwheel (probably within the week)
  • Build 3.7 wheels
    • Some way to not fail the whole build on their failure right now?

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #1051 into trunk will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk    #1051      +/-   ##
==========================================
- Coverage   91.93%   91.57%   -0.36%     
==========================================
  Files         846      845       -1     
  Lines      151280   151218      -62     
  Branches    13194    13189       -5     
==========================================
- Hits       139074   138480     -594     
- Misses      10108    10616     +508     
- Partials     2098     2122      +24

@altendky
Copy link
Member Author

altendky commented Aug 28, 2018

Looks like they are building now for Windows and Linux.

AppVeyor log
AppVeyor artifacts

Twisted-18.7.0.dev0-cp27-cp27m-win32.whl
Twisted-18.7.0.dev0-cp27-cp27m-win_amd64.whl
Twisted-18.7.0.dev0-cp34-cp34m-win32.whl
Twisted-18.7.0.dev0-cp34-cp34m-win_amd64.whl
Twisted-18.7.0.dev0-cp35-cp35m-win32.whl
Twisted-18.7.0.dev0-cp35-cp35m-win_amd64.whl
Twisted-18.7.0.dev0-cp36-cp36m-win32.whl
Twisted-18.7.0.dev0-cp36-cp36m-win_amd64.whl

Travis log

Twisted-18.7.0.dev0-cp27-cp27m-manylinux1_i686.whl
Twisted-18.7.0.dev0-cp27-cp27m-manylinux1_x86_64.whl
Twisted-18.7.0.dev0-cp27-cp27mu-manylinux1_i686.whl
Twisted-18.7.0.dev0-cp27-cp27mu-manylinux1_x86_64.whl
Twisted-18.7.0.dev0-cp34-cp34m-manylinux1_i686.whl
Twisted-18.7.0.dev0-cp34-cp34m-manylinux1_x86_64.whl
Twisted-18.7.0.dev0-cp35-cp35m-manylinux1_i686.whl
Twisted-18.7.0.dev0-cp35-cp35m-manylinux1_x86_64.whl
Twisted-18.7.0.dev0-cp36-cp36m-manylinux1_i686.whl
Twisted-18.7.0.dev0-cp36-cp36m-manylinux1_x86_64.whl

Aside from making sure they actually work and this is a sensible set of wheels... the big pieces I have in mind are:

edit: merged checklist above

@altendky altendky changed the title [9217] [WIP] Build lots of wheels [9217] Build lots of wheels Sep 24, 2018
@altendky altendky closed this Nov 6, 2018
@altendky altendky reopened this Nov 6, 2018
@altendky
Copy link
Member Author

altendky commented Feb 5, 2019

Trunk is broken. I guess I'll update this branch when trunk is ok again.

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s do it.

@glyph glyph merged commit a1cf869 into twisted:trunk Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants