Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
9544 NPrescott adbapi logging #1074
Prevent "noisy" log-level from logging username and password information on connect.
@@ Coverage Diff @@ ## trunk #1074 +/- ## ========================================== - Coverage 91.92% 91.91% -0.01% ========================================== Files 844 844 Lines 151118 151023 -95 Branches 13185 13182 -3 ========================================== - Hits 138911 138815 -96 - Misses 10111 10113 +2 + Partials 2096 2095 -1
left a comment
Hi @NPrescott, this looks good to me, particularly in light of the historical context you provided in the ticket — that makes this very easy to
The only feedback I have is that the newsfragment could better indicate the why of the change: e.g., "and not the connection arguments, which may contain credentials".
I've kicked off the buildbot, which must pass before I can merge. I probably won't be around later tonight to do the actual merge, so if you have time to tweak the newsfile before the PR is merged it would be appreciated. I won't hold merging for that change, though — it is good enough as-is.