Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11799 annotations for getPrimes #11800

Merged
merged 5 commits into from
Mar 16, 2023
Merged

#11799 annotations for getPrimes #11800

merged 5 commits into from
Mar 16, 2023

Conversation

glyph
Copy link
Member

@glyph glyph commented Jan 17, 2023

Scope and purpose

Fixes #11799

Add some annotations for getPrimes and its overrides.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@glyph
Copy link
Member Author

glyph commented Jan 17, 2023

please review

@chevah-robot chevah-robot requested a review from a team January 17, 2023 02:12
@glyph glyph changed the title annotations for getPrimes [11799] annotations for getPrimes Jan 17, 2023
@glyph glyph changed the title [11799] annotations for getPrimes #11799 annotations for getPrimes Jan 17, 2023
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! I will leave filing a ticket to your discretion.

Thanks!

src/twisted/conch/openssh_compat/factory.py Outdated Show resolved Hide resolved
@glyph glyph enabled auto-merge March 16, 2023 19:13
@glyph glyph force-pushed the 11799-getPrimes-annotation branch from 48116cd to ae172de Compare March 16, 2023 19:23
@glyph glyph merged commit 1278640 into trunk Mar 16, 2023
@glyph glyph deleted the 11799-getPrimes-annotation branch March 16, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twisted.conch.ssh.factory.SSHFactory.getPrimes and its overrides are not type annotated
4 participants