#11822 filepath annotations #11823
#11822 filepath annotations #11823
Conversation
|
review please |
|
haven't run the tests yet myself, but the type-check should be clean |
|
So, those test failures were embarrassing. Let's try that again… |
|
Looks like I've got a few minor coverage gaps which should be addressed but otherwise I think we're good now |
…lesystem enforcement
|
OK. Coverage gaps all addressed. |
There was a problem hiding this comment.
I don't have much experience with Python typing.
I did a very quick look and it looks ok
I hope @graingert can also take another look to check all is ok.
Since this is waiting in the queue since March, as long as the tests are green, I think that this can be merged.
Thanks Glyph for the update.
|
thanks @adiroiban ! I'm happy to take any post-hoc feedback from @graingert (or anyone else for that matter) but as you note, this has been waiting since March, so let's get it out of the queue and move things along, there are plenty of other PRs that need review attention… |
| def archive(self): | ||
| return self |
There was a problem hiding this comment.
this is the only method not annotated, it should probably be -> Self: # type: ignore[override]
| @@ -273,17 +283,87 @@ def _secureEnoughString(path): | |||
| return _coerceToFilesystemEncoding(path, secureishString) | |||
There was a problem hiding this comment.
this is missing a type annotation - should be def _secureEnoughString(path: AnyStr) -> AnyStr: ...
Scope and purpose
Fixes #11822
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.