Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax IReactorProcess.spawnProcess to more accurately reflect impleme… #11825

Merged
merged 4 commits into from
May 9, 2023

Conversation

glyph
Copy link
Member

@glyph glyph commented Mar 17, 2023

…ntations

Scope and purpose

Fixes #11824

Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.

Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.

Add mentions of things that are not covered here and are planed to be done in separate PRs.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@glyph
Copy link
Member Author

glyph commented Mar 17, 2023

please review

1 similar comment
@glyph
Copy link
Member Author

glyph commented Mar 17, 2023

please review

@chevah-robot chevah-robot requested a review from a team March 17, 2023 02:34
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This matches my own experience with alternative (test) implementations. Thank you and please merge!

@glyph
Copy link
Member Author

glyph commented May 3, 2023

Thanks for the review @twm!

@glyph glyph merged commit 34b161e into trunk May 9, 2023
@glyph glyph deleted the 11824-spawn-types branch May 9, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IReactorProcess.spawnProcess is too strict
3 participants