Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11830 make process tests more reliable #11831

Merged
merged 9 commits into from
Mar 28, 2023
Merged

Conversation

glyph
Copy link
Member

@glyph glyph commented Mar 21, 2023

Scope and purpose

Fixes #11830

this splits out the file_actions calculation to its own function so tricky edge cases can be tested independently, and it fixes some getrlimit bugginess on macOS

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@glyph
Copy link
Member Author

glyph commented Mar 21, 2023

please review

@chevah-robot chevah-robot requested a review from a team March 21, 2023 10:09
Copy link
Contributor

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the twisted specific bits here, but I looked at the docs for posix_spawn and the test cases appear correct

@glyph
Copy link
Member Author

glyph commented Mar 28, 2023

OK, I'm going to accept that review from Paul, because the correctness of the posix_spawn bits is the part that needs review, the "twisted-specific" bits are not interesting :)

@glyph glyph merged commit 36d8fa3 into trunk Mar 28, 2023
@glyph glyph deleted the 11830-posix_spawn-file-actions branch March 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process tests are flaky
3 participants