Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Ed25519 SSH keys #1210

Merged
merged 6 commits into from
Mar 28, 2020
Merged

Add support for Ed25519 SSH keys #1210

merged 6 commits into from
Mar 28, 2020

Conversation

cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Dec 22, 2019 •
edited
Loading

Portions of this are based on work by the0id the0idelson@gmail.com in
#644.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/8966
  • The changes pass minimal style checks
  • I have created a newsfragment in src/twisted/conch/newsfragments/
  • I have updated the automated tests.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.

rodrigc
rodrigc approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@rodrigc rodrigc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, nice!

@rodrigc
Copy link
Contributor

rodrigc commented Mar 28, 2020

I also did the following:

  • used ssh-keygen to generate an ed25519 key, added it to authorized_keys on one of my systems
  • I checked out your branch and did: pip install -e ".[conch]"
  • I did: conch --identity=$PWD/id_ed25519 root@myhost
  • login worked

@rodrigc rodrigc merged commit 62ca995 into twisted:trunk Mar 28, 2020
@cjwatson cjwatson deleted the 8966-conch-ed25519 branch February 6, 2022 13:45
cjwatson pushed a commit to cjwatson/twisted that referenced this pull request Feb 11, 2022
@rodrigc @cjwatson
Merge pull request twisted#1210 from cjwatson/8966-conch-ed25519
c48f874 
Add support for Ed25519 SSH keys

Author: cjwatson
Reviewer: rodrigc
Fixes: ticket:8966

twisted#1210
@richvdh richvdh mentioned this pull request May 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigc rodrigc rodrigc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjwatson @rodrigc @twm @glyph