Disable pycodestyle for now #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthuurne
force-pushed
the
disable_pycodestyle
branch
from
05baf7f
to
bcdbe8c
Compare
The incremental code style checking is blocking automated substitutions on the source tree, since any change close to a piece of pre-existing code that is not style compliant will make pycodestyle complain. This happens so many times that correcting these manually is too much work. After adopting Black, there will either be no need for style checking or it can be done with a much smaller ruleset.
mthuurne
force-pushed
the
disable_pycodestyle
branch
from
bcdbe8c
to
6d3807c
Compare
twm
approved these changes
Jul 25, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incremental code style checking is blocking automated substitutions on the source tree (like #1360 and #1361, but touching more files), since any change close to a piece of pre-existing code that is not style compliant will make pycodestyle complain. This happens so many times that correcting these manually is too much work.
After adopting Black (see #1134), there will either be no need for style checking or it can be done with a much smaller ruleset.
Contributor Checklist:
reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.