upgrade to declarative setuptools #1428

graingert · 2020-10-08T12:18:07Z

Contributor Checklist:

The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/9999
I ran tox -e black-reformat to format my patch to meet the Twisted Coding Standard
I ran additional checks listed at Getting Your Patch Accepted
I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
I have updated the automated tests.
I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.

also remove BuildPy3

io.open(str), results in IO[Any]

graingert · 2020-10-08T19:26:49Z

src/twisted/python/_setup.py

+        # are not yet set up when this code is executed.
+        "ext_modules": extensions,
+        "cmdclass": {"build_ext": my_build_ext},
+        "extras_require": _EXTRAS_REQUIRE,


currently _EXTRAS_REQUIRE is in python to save on duplication eg with twisted[all_non_platform]

graingert · 2020-10-09T13:19:48Z

One concern I have though is that test_mail.py and test_options.py are removed, but the code that they're testing is not. This is probably related to the removal of the notPortedModules list, but it seems like something that should be resolved in a more thorough matter, perhaps in a separate PR.

I think reverting the tests and fixing them is on the table. Or deleting these notPortedModules. I don't think they do any harm in the dist though

wsanchez · 2020-10-09T16:21:37Z

One concern I have though is that test_mail.py and test_options.py are removed, but the code that they're testing is not. This is probably related to the removal of the notPortedModules list, but it seems like something that should be resolved in a more thorough matter, perhaps in a separate PR.

I think reverting the tests and fixing them is on the table. Or deleting these notPortedModules. I don't think they do any harm in the dist though

I agree with @mthuurne that removing them is problematic…

wsanchez · 2020-10-09T16:21:52Z

WHOAH oops didn't mean to close

wsanchez · 2020-10-09T16:23:26Z

I think this is a lot more readable and I like moving the static config back up to the top of the project. I've never really used setup.cfg so I'm not aware of what pitfalls may exist, if any, or what the best way to verify the built result is OK, though I guess that's what pre-releases are for…?

graingert · 2020-10-09T16:25:07Z

or what the best way to verify the built result is OK, though I guess that's what pre-releases are for…?

a pypi pre-release or a test.pypi.org upload would work. Tox does run this so it mostly works and the wheels seem fine.

you can run python setup.py sdist bdist_wheel and inspect the results

wsanchez · 2020-10-09T16:31:59Z

a pypi pre-release or a test.pypi.org upload would work. Tox does run this so it mostly works and the wheels seem fine.

I like that.

@rodrigc @glyph How do you feel about giving one of us upload permissions to Twisted on test.pypi.org?

graingert · 2020-10-09T17:01:17Z

@wsanchez you could rename the setup.cfg[metadata].name key

rodrigc · 2020-10-09T17:33:52Z

@rodrigc @glyph How do you feel about giving one of us upload permissions to Twisted on test.pypi.org?

I can't help you with that. I also am blocked on that: #1423 (comment)

graingert · 2020-10-09T17:40:40Z

@rodrigc you appear to be soul maintainer of https://test.pypi.org/project/Twisted/ you could add @wsanchez as a maintainer

rodrigc · 2020-10-09T17:52:29Z

Interesting. I don't know when I was granted that access to test.pypi.org. For now I am going to focus on moving forward with the release, before giving additional people access to PyPI resources. If Glyph or Hawkowl want to grant access, I will defer to their wishes.

glyph · 2020-10-09T17:54:55Z

@rodrigc You weren't "granted access" - you own the project in its entirety on test.pypi.org; the data there does not derive from PyPI at all.

https://test.pypi.org/project/Twisted/

I didn't even have an account on test.pypi.org — I just made one, so at least I got "glyph" :). Please go ahead and give everybody who needs it access to test PyPI (including me :)).

rodrigc · 2020-10-09T18:11:13Z

@glyph OK, I granted you and @wsanchez access to https://test.pypi.org/ . I couldn't find an account for hawkowl on test.pypi.org to grant access.

This reverts commit 7c1ff22.

graingert · 2020-10-10T09:40:53Z

I agree with @mthuurne that removing them is problematic…

I've restored the tests that were "commented out" in src/twisted/python/_setup.py, ported just enough code to get them to run the test setUps and skipped every test that fails

wsanchez

cool, thanks

graingert marked this pull request as draft October 8, 2020 12:18

graingert force-pushed the move-more-content-into-static-package-metadata branch 10 times, most recently from 958548a to c33a81b Compare October 8, 2020 14:20

graingert added 6 commits October 8, 2020 16:38

move more content into static package metadata

bb4f472

also remove BuildPy3

add newsfragment

160ac96

update docs

83a833d

remove notPortedModules

b44c951

fix mypy

2802518

io.open(str), results in IO[Any]

remove failing tests

7c1ff22

graingert force-pushed the move-more-content-into-static-package-metadata branch from c33a81b to 7c1ff22 Compare October 8, 2020 15:42

graingert marked this pull request as ready for review October 8, 2020 15:44

graingert closed this Oct 8, 2020

graingert reopened this Oct 8, 2020

switch to declarative setuptools

fe6dd19

graingert changed the title ~~move more content into static package metadata~~ switch to declarative setuptools Oct 8, 2020

graingert requested a review from wsanchez October 8, 2020 19:24

graingert commented Oct 8, 2020

View reviewed changes

graingert closed this Oct 8, 2020

graingert reopened this Oct 8, 2020

graingert changed the title ~~switch to declarative setuptools~~ upgrade to declarative setuptools Oct 8, 2020

graingert closed this Oct 8, 2020

graingert reopened this Oct 8, 2020

graingert added 2 commits October 9, 2020 14:16

Merge branch 'trunk' into move-more-content-into-static-package-metadata

1122626

add py39 trove classifier

e8a7316

graingert requested a review from mthuurne October 9, 2020 13:17

graingert closed this Oct 9, 2020

graingert reopened this Oct 9, 2020

bump requires-python for typing.TYPE_CHECKING

16a0299

wsanchez closed this Oct 9, 2020

wsanchez reopened this Oct 9, 2020

graingert force-pushed the move-more-content-into-static-package-metadata branch 2 times, most recently from 9a52f95 to 16a0299 Compare October 9, 2020 19:22

graingert added 3 commits October 10, 2020 09:32

Merge branch 'trunk' into move-more-content-into-static-package-metadata

8b679c8

Revert "remove failing tests"

4327591

This reverts commit 7c1ff22.

port just enough of twisted.mail to support running the test setUps

d50e810

graingert force-pushed the move-more-content-into-static-package-metadata branch from 291b1f0 to d50e810 Compare October 10, 2020 09:28

wsanchez approved these changes Oct 10, 2020

View reviewed changes

graingert merged commit 1292fad into twisted:trunk Oct 10, 2020

graingert deleted the move-more-content-into-static-package-metadata branch October 10, 2020 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to declarative setuptools #1428

upgrade to declarative setuptools #1428

graingert commented Oct 8, 2020 •

edited

graingert Oct 8, 2020

graingert commented Oct 9, 2020

wsanchez commented Oct 9, 2020

wsanchez commented Oct 9, 2020

wsanchez commented Oct 9, 2020

graingert commented Oct 9, 2020 •

edited

wsanchez commented Oct 9, 2020

graingert commented Oct 9, 2020

rodrigc commented Oct 9, 2020 •

edited

graingert commented Oct 9, 2020

rodrigc commented Oct 9, 2020

glyph commented Oct 9, 2020

rodrigc commented Oct 9, 2020

graingert commented Oct 10, 2020

wsanchez left a comment

upgrade to declarative setuptools #1428

upgrade to declarative setuptools #1428

Conversation

graingert commented Oct 8, 2020 • edited

Contributor Checklist:

graingert Oct 8, 2020

Choose a reason for hiding this comment

graingert commented Oct 9, 2020

wsanchez commented Oct 9, 2020

wsanchez commented Oct 9, 2020

wsanchez commented Oct 9, 2020

graingert commented Oct 9, 2020 • edited

wsanchez commented Oct 9, 2020

graingert commented Oct 9, 2020

rodrigc commented Oct 9, 2020 • edited

graingert commented Oct 9, 2020

rodrigc commented Oct 9, 2020

glyph commented Oct 9, 2020

rodrigc commented Oct 9, 2020

graingert commented Oct 10, 2020

wsanchez left a comment

Choose a reason for hiding this comment

graingert commented Oct 8, 2020 •

edited

graingert commented Oct 9, 2020 •

edited

rodrigc commented Oct 9, 2020 •

edited