Move iocpsupport to external dist #1446
Conversation
graingert
force-pushed
the
move-iocpsupport-to-external-dist
branch
from
501977f
to
562571a
Compare
graingert
force-pushed
the
move-iocpsupport-to-external-dist
branch
from
562571a
to
8c4b9f5
Compare
There was a problem hiding this comment.
Thanks for working on this.
This should make Twisted deployment simpler and faster.
I am +1 for moving iocpsupport as a separate package.
I am -1 for moving the source code outside of twisted/twisted
The tests for iocpsupport are part of the main twisted tests...so is best to have the code in the same repo.
Maybe have the twisted-iocpsupport source code moved to src/twisted_iocpsupprt package.
In root we can have a setup_twisted_iocpsupport.py which takes care of the wheel build.
We can have a github action to build the iocpsupport wheel when any file is modified inside the src/twisted_iocpsupport dir.
We can have a github action to publish the iocpsupport wheel when a tag starting with 'iocpsupport-VNNN' is created.
In tox, when tests are executed, iocpsupport is installed from the binary wheel.
In tox, we can have an option (commented / uncommented line) to build and use the code from src/twisted_iocpsupport when we want to develop iocpsupport
|
For reference... and I think this should be in the PR description. The code was moved here https://github.com/graingert/twisted-iocpsupport |
| "send", | ||
| ] | ||
|
|
||
| from twisted_iocpsupport.iocpsupport import ( |
There was a problem hiding this comment.
can we have all this as from twisted_iocpsupport import recv ?
And maybe add a deprecation so that in the future the code will import directly from twisted_iocpsupport and not from this redirection.
There was a problem hiding this comment.
probably worth doing https://github.com/asottile/reorder_python_imports everywhere in a followup
There was a problem hiding this comment.
Well.. in Twisted we have backward compatibility policy, so you can't remove something from the public namespace without a prior deprecation warning.
But I can create the deprecation part after this is merged.
|
For the newsfragment. My suggestion. |
setup.cfg
Outdated
| @@ -31,6 +31,7 @@ install_requires = | |||
| Automat >= 0.8.0 | |||
| hyperlink >= 17.1.1 | |||
| attrs >= 19.2.0 | |||
| twisted-iocpsupport ~= 0.0.1; platform_system == "Windows" | |||
There was a problem hiding this comment.
| twisted-iocpsupport ~= 0.0.1; platform_system == "Windows" | |
| twisted-iocpsupport ~= 1.0; platform_system == "Windows" |
nope |
another crack at this allows a single source .whl for mac/linux and windows 🎉 https://github.com/twisted/twisted/pull/812/files
Contributor Checklist:
tox -e black-reformatto format my patch to meet the Twisted Coding Standardreviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.