Removed dubious usage of pyOpenSSL's NETSCAPE #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use the normal and idiomatic `dump_publickey` method.
|
Thanks for the PR. Is there a ticket for this PR? Please note that we now (should) have a functional travis test suite and PR are supposed to pass those tests. |
|
Tests green. |
|
this patch is also updated pyopenssl dependency to 16.0.0 . I think that dropping support for pyopenssl 0.13.0 should be discussed over the mailing list. while pyopenssl 16.0.0 did a lot of great things it also has a few regressions (ex pyca/pyopenssl#456) ... and this is scary :) pyca/pyopenssl#447 |
|
@alex please coordinate with @glyph on the Trac ticket page to see how and when to merge this branch https://twistedmatrix.com/trac/ticket/8441 Thanks! |
Current coverage is 90.71% (diff: 100%)@@ trunk #146 diff @@
==========================================
Files 836 802 -34
Lines 144690 142854 -1836
Methods 0 0
Messages 0 0
Branches 13573 12514 -1059
==========================================
- Hits 130166 129584 -582
+ Misses 12289 10878 -1411
- Partials 2235 2392 +157
|
|
Thanks @adiroiban, @alex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use the normal and idiomatic
dump_publickeymethod.https://twistedmatrix.com/trac/ticket/8441