[10070] Fix passing str command arguments to spawProcess with None encoding. #1501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
This tries to fix https://twistedmatrix.com/trac/ticket/10070
Default to utf-8 when encoding is None.
This is similar to twisted/towncrier#300
I am not a Py 3 expert, but my understand is that a standard stream has encoding None, when it is piped.
This is other info I found https://stackoverflow.com/questions/492483/setting-the-correct-encoding-when-piping-stdout-in-python
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standardreviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.