Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10070] Fix passing str command arguments to spawProcess with None encoding. #1501

Closed
wants to merge 4 commits into from

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Dec 28, 2020

Scope and purpose

This tries to fix https://twistedmatrix.com/trac/ticket/10070

Default to utf-8 when encoding is None.

This is similar to twisted/towncrier#300

I am not a Py 3 expert, but my understand is that a standard stream has encoding None, when it is piped.

This is other info I found https://stackoverflow.com/questions/492483/setting-the-correct-encoding-when-piping-stdout-in-python

Contributor Checklist:

@adiroiban
Copy link
Member Author

Looks like there is another PR #1499 :)

@rodrigc
Copy link
Contributor

rodrigc commented Jan 3, 2021

@adiroiban Please stop working on this. I have closed Twisted bug 10070 and re-opened 10069. I mentioned here: https://twistedmatrix.com/pipermail/twisted-python/2020-December/065358.html that I am working on this problem, and collaborating with the Buildbot developers.

As I mentioned on the mailing list here: https://twistedmatrix.com/pipermail/twisted-python/2020-December/065365.html , I don't currently need your help on this, but will ask if I need any help from you.

Thanks.

@rodrigc rodrigc closed this Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants